This repository has been archived by the owner on Nov 1, 2022. It is now read-only.
show more context for errors from fluxctl #1615
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Errors in fluxctl are unwrapped before printing since we want to format flux-specific errors specially, and they can come wrapped. However, the unwrapping can lead to losing context when printing non-flux-specific errors. For instance, after https://github.com/justinbarrick/go-k8s-portforward/pulls/3 we display the following when a kubeconfig file isn't found: Error: invalid configuration: no configuration has been provided Run 'fluxctl identity --help' for usage. Which is the cause of a much more helpful error when in full: Error: Could not load kubernetes configuration file: invalid configuration: no configuration has been provided Run 'fluxctl identity --help' for usage. This change removes the unwrapping for non-flux-specific errors.
2opremio
force-pushed
the
fluxctl-error-context
branch
from
9fa92d8
to
a5ebc21
Compare
|
This changes the behaviour when there's a |
My intention was to unify the error output, but in hindsight it just provides redundant information, so I reverted to the original behavior. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Errors in fluxctl are unwrapped before printing since we want to
format flux-specific errors specially, and they can come wrapped.
However, the unwrapping can lead to losing context when printing
non-flux-specific errors.
For instance, after
https://github.com/justinbarrick/go-k8s-portforward/pulls/3 we display
the following when a kubeconfig file isn't found:
Which is the cause of a much more helpful error when in full:
This change removes the unwrapping for non-flux-specific errors.